Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The guide does not explain that Arrow objects support equality, ordering and sorting, leaving their timezone behavior unclear. Add a
Comparesection afterProperties, as suggested in #981.The examples show equal instants with different offsets, sorting, and comparisons with datetime objects. The text explains that Arrow follows Python's datetime rules, including the repeated-hour case where comparing local times ignores
fold. A short example shows how converting to UTC distinguishes those instants.Validation on Windows with Python 3.12: all 14 new example statements pass doctest; the full suite passes with 1,901 tests and one existing platform skip; all configured pre-commit hooks pass; doc8 and the Sphinx HTML build with warnings treated as errors pass. Other Python versions and operating systems were not tested locally. No library code changes.
Closes #981.
Pull Request Checklist
masterbranch.