Repository navigation
Fix span()/ceil() when the next frame boundary falls in a DST gap - #1364
Open
uditjainstjis wants to merge 1 commit into
Open
uditjainstjis wants to merge 1 commit into
uditjainstjis wants to merge 1 commit into
Conversation
span() built the ceiling by shifting the floor with check_imaginary=True, which
moves a nonexistent boundary (e.g. America/Santiago skips 2022-09-11 00:00-01:00)
forward, so ceil("day") on 2022-09-10 returned 2022-09-11T01:59:59.999999-03:00.
Keep the exact boundary; one microsecond before it is the frame's last instant.
Closes arrow-py#1124
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1364 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.Description of Changes
span()builds the ceiling by shifting the floor forward one frame withcheck_imaginary=True. When that next boundary does not exist because it falls in a DST gap, the shift moves it forward. America/Santiago skips 2022-09-11 00:00–01:00, so:The shift now keeps the exact boundary (
check_imaginary=False), and one microsecond before it is the last real instant of the frame. Boundaries that exist are unaffected.Tests:
test_span_day_before_dst_gap_at_midnightfails without the change and passes with it;test_span_day_of_dst_gap_at_midnightcovers the day of the gap. Full suite: 1904 passed; pre-commit hooks pass.Closes: #1124