Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 6, 2026 21:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of Changes
Locale month names, day names, and meridians are literal text, but their punctuation is currently interpolated into regular expressions without escaping. For example, Catalan
gen.matchesgenx, leading to a TypeError during date construction; malformed Armenian PM markers can silently produce an AM time.Escape these choices before joining the alternatives. Add regression coverage for month/day abbreviations, meridians, and alternative-format fallback, while verifying correctly punctuated locale strings still parse.
Validation
git diff --checkpassedTested on Linux with Python 3.12.14. The hosted Python/OS matrix has not run on this commit yet. This patch was prepared with OpenAI Codex assistance.