Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 6, 2026 21:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of Changes
is_betweenconverts all three dates to floating-point timestamps. Distinct microseconds can collapse for early or late years. For example, a date one microsecond afterArrow(2500, 1, 1)is incorrectly considered outside the open interval ending two microseconds after it. Inclusive bounds can also admit a target outside an interval when its timestamp rounds to an endpoint.Compare exact timedeltas relative to a fixed UTC-aware epoch instead. This preserves microseconds and UTC-instant ordering, including DST folds, without constructing out-of-range UTC datetimes at year 1 or 9999.
Add 28 regression/compatibility cases covering six years, all four bounds, mixed offsets, UTC datetime boundaries, and both DST fold values.
Validation
git diff --checkpassedTested on Linux with Python 3.12.14. No hosted Python/OS matrix result is claimed yet. Prepared with OpenAI Codex assistance.