Repository navigation
Installer: accept stock VLC.app without a video_filter folder - #9
Merged
Merged
Conversation
VLC for macOS keeps every plugin directly in Contents/MacOS/plugins and scans it recursively, so video_filter only exists where icop was installed before. The installer required that folder and failed on every fresh VLC.app, including Homebrew's VLC 3.0.24 in the v0.1.7 release build. On macOS, accept Contents/MacOS/plugins/video_filter when its parent holds the VLC executable, decide on sudo by the folder the install creates it in, and let the existing mkdir -p create it. Verified against stock VLC 3.0.24 (Homebrew DMG): dry run, install (7 files) and uninstall; a non-VLC folder is still rejected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v0.1.7 release (run 36798954688) failed on macOS ARM64 and x86_64 at the bundled-installer dry run:
Stock VLC.app keeps all plugins directly in
Contents/MacOS/pluginsand scans that folder recursively, sovideo_filteronly exists where icop was installed before. The installer required that folder, so it failed on every fresh VLC.app: Homebrew's VLC 3.0.24 in CI, and any first-time user. Local tests passed only because the test Mac already had the folder.Fix
Contents/MacOS/plugins/video_filterwhen its parent folder exists next to theVLCexecutable. The existingmkdir -pthen createsvideo_filter.sudois needed by the folder the install createsvideo_filterin.Verification
Against stock VLC 3.0.24 (Homebrew DMG):
--dry-runpasses.video_filterwith all 7 files.--uninstallremoves them..appis still rejected.After merging, the release needs a new tag (v0.1.7 → this fix, or v0.1.8).
🤖 Generated with Claude Code