Repository navigation
Fix: Enable composite types to act as maps in queries and calculations - #3045
Merged
zachdaniel merged 1 commit intoOct 19, 2026
Merged
Conversation
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since function arguments are checked against their declared types (#2948),
get_pathrefuses composite types.Ash.Query.Function.GetPathdeclares:mapfor its first argument, and a composite type neither is:mapnor acts as one. #2948 gaveacts_as(_), do: :mapto structs, tuples, keywords and embedded resources, but not to composite types.As a result, every read that uses
get_path,attr[:field]or theat_pathinput predicate on a composite attribute raises, including the usage documented under "Composite Types" inAsh.Type:This worked for me before 3.33.6, both in data layers that compile composite paths via
composite_types/1and in memory.Change
truefromcomposite?/1andnilfromacts_as/1,Ash.Type.acts_as/2now falls back to:map.acts_as/1keeps that answer.{:array, :map}.composite?/1passes through to the subtype.Contributor checklist
Leave anything that you believe does not apply unchecked.