Repository navigation
zig fmt: three files main's fmt check refuses - #616
Merged
Merged
Conversation
…--check wants them
Owner
|
Thank you, @BobClawblaw. This is merged into main (60aa6ef), your commit as it was, so main passes |
Open
cwschroeder
added a commit
to cwschroeder/TensorFold
that referenced
this pull request
Oct 11, 2026
The fmt check refused tokenizer.zig, lane_host.zig and cuda.zig. This PR changes none of them; they come unformatted from the base 1f938b1, and upstream formats tokenizer.zig and cuda.zig in ashhart#616. Formatted with Zig 0.17.0, the version the workflow uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's
fmtjob (zig fmt --check build.zig zig) fails on current main in three files, so it fails on every open PR too (#598 among them):zig/src/core/tokenizer/tokenizer.zig: five test struct literals with several fields to a linezig/src/native/cuda.zig: one line's spacingzig/tests/moe_bench.zig: one blank lineThis is
zig fmt(0.17.0) on those files and nothing else. Every change is whitespace: each file's bytes without spaces, tabs and newlines are identical before and after.zig fmt --check build.zig zigis clean afterwards.