Repository navigation
native: a CUDA family's prompt cache, weight share and open errors come from its own declarations - #762
Open
Bizuayeu wants to merge 1 commit into
Open
native: a CUDA family's prompt cache, weight share and open errors come from its own declarations#762Bizuayeu wants to merge 1 commit into
Bizuayeu wants to merge 1 commit into
Conversation
…me from its own declarations The CUDA host wired Nemotron's prompt-cache copies, rules and budget in by name. They now come from the family's `snap_*` declarations through `cuda_snaps.zig`: a family without `snap_save` gets no prompt cache, `snap_ready` sets aside its state buffers, and `snap_grid` makes the store keep states only on the family's chunk starts (a family whose rows depend on where a prompt's chunks begin), and `warm_quiet` turns on the quiet-turn reply prefill (warm turns and the store's `.waits`). Nemotron declares `warm_quiet` and no grid and keeps 1.0.9's rules: any row, the head one token on, warm turns, the same budget. Three more hooks for a family split over hosts: `weightShare` (the weights this rank holds, for the memory check), `explains_open` (the family's own text for an open error) and the learner only for a family with `slide`. Nemotron's open, cache, warm turns and --slide are unchanged; `cuda_snaps.zig`'s test covers the rules each way.
Bizuayeu
force-pushed
the
pr/native-family-hooks
branch
from
October 13, 2026 19:23
bf10491 to
185bc33
Compare
Contributor
Author
|
Rebased onto 1.0.9. Its Nemotron store gained warm turns ( |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The CUDA host wired Nemotron's prompt-cache copies, rules and budget in by name. They now come from the family's
snap_*declarations throughcuda_snaps.zig: a family withoutsnap_savegets no prompt cache,snap_readysetsaside its state buffers, and
snap_gridmakes the store keep states only on the family's chunk starts (for a familywhose rows depend on where a prompt's chunks begin). A family that declares
warm_quietgets 1.0.9's warm turns(
.warm = .waits). Nemotron declareswarm_quietand no grid and keeps 1.0.9's rules: any row, the head onetoken on, warm turns, the same budget.
Three more hooks for a family split over hosts:
weightShare(the weights this rank holds, for the memory check),explains_open(the family's own text for an open error) and the learner only for a family withslide. TheGLM-5.3-Flash family (#548) uses all of them.
Receipt
c36b536d) plus this change; one GB10 (DGX Spark, sm_121, CUDA 13.3).--slideare unchanged (the same calls and rules, now through thefamily's declarations).
zig build test-cuda-host: 430 passed, 0 failed; the new "a family with snap_grid keeps on its chunk starts, anyother at any row as Nemotron does" needs this change.
zig build test: 620 passed, 5 skipped, 0 failed.zig fmt --check: clean.lean_check: 538, as main.weightShare,explains_openand theslideguard are not covered by a host test: they are branches ofopenWith, which needs a GPU and a real checkpoint to reach. The GLM-5.3-Flash family's runs at TP=2 and TP=3 (Zig CUDA ports: shared layers belowlanes.Backend, and one place to coordinate them #548) go through all three.Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo.