Repository navigation
cuda: the staged NVFP4 prompt entries leave an expert's items alone (skip), as the decode form does - #764
Conversation
59068ac to
6f3991b
Compare
|
Rebased onto 1.0.9 ( |
…skip), as the decode form does A family that computes one expert itself (GLM-5.3-Flash stacks its BF16 shared expert as the last expert id) plans every pair together and has the grouped kernels skip that id. The decode form already takes skip; Grouped.prompt refused it with OptionNotBuilt for NVFP4. The prompt entries now take skip and return before staging any rows of that expert's items. Nemotron passes -1, so its bits do not change. quant-ref now checks it: with the shared expert skipped, its pairs' prompt rows keep what was there and every other pair's row equals the run without skip, for fp8 and nvfp4.
6f3991b to
3a576e3
Compare
|
Rebased onto 1.0.10 ( |
Recall (off unless asked for), model discovery's reasoning efforts (#819), the NVFP4 prompt entries' skip (#764) and Nemotron's CUDA decode router, top-k and add_moe_norm (#833), gated on the candidate before Living Weights' key, snapshot and rollback. Two conflicts: the CHANGELOG's Unreleased list, where both sides' lines are kept in landing order, and the server main's imports, where all four are kept.
|
Thank you, @Bizuayeu. Letting the NVFP4 prompt entries skip an expert, as the decode entries already do, removes a real blocker for a family that computes its shared expert itself. It ships in TensorFold 1.0.12 under your name ( On a GB10, No caller passes a real expert id yet, so quant-ref alone covers the skip path until a family such as GLM-5.3-Flash on CUDA starts passing its shared expert. Posted by Ash's AI Assistant Synthena |
What this changes
A family that computes one expert itself (GLM-5.3-Flash stacks its BF16 shared expert as the last expert id) plans
every pair together and has the grouped kernels skip that id. The decode form already takes
skip;Grouped.promptrefused it withOptionNotBuiltfor NVFP4. The prompt entries now takeskipand return beforestaging any rows of that expert's items. Nemotron passes -1, so its bits do not change.
Receipt
6c5e5192) plus this change; one GB10 (DGX Spark, sm_121, CUDA 13.3).skip= -1 the kernels run as before.tf-cuda-test quant-refnow runs the prompt gate-up anddown twice on one routed plan (300 rows, 4 slots, the shared expert last), without and with the shared expert
skipped: its pairs' rows keep what the buffer held, and every other pair's row equals the run without skip, byte
for byte, for fp8 and nvfp4.
tf-cuda-test quant-ref: 4 PASS, 0 FAIL; the nvfp4 skip check fails on main withOptionNotBuilt.zig build test-cuda-host: 451 passed, 0 failed.zig build test: 553 passed, 5 skipped, 0 failed.zig fmt --check: clean.lean_check: 523, as main.Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo.