Repository navigation
Fix C++20 lambda capture warnings - #359
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: libE57Format will not accept generative "AI" PRs at this time
Type
Summary
Replace the implicit [=] captures in getPointProto and getAngleProto
with explicit C++14-compatible capture lists.
Rationale
C++20 reports deprecated implicit this captures caused by the [=]
default capture. Explicit captures make the intent clear, remove the
warnings, and preserve C++14 compatibility without changing functionality.
Additional Notes
The project was configured and built successfully with GCC and c++14/20
The test executable reported 27 passing tests and 5 skipped tests because
test data was unavailable.
clang-format was run using the project configuration.
Checklist