Repository navigation
Conversation
jjhelmus
approved these changes
Oct 21, 2026
Contributor
|
Note: This should only be merged alone with a fix for the symbols. This will fail for 3.16 |
jjhelmus
added a commit
that referenced
this pull request
Oct 23, 2026
Statically link the helper functions used for half-precision conversions used in Python 3.16 from libgcc.a. This is not needed when cross-compiling as only an older libgcc is available in the sysroot. Native builds have the newer libgcc that is included in the LLVM bundle. Include checks for GCC symbol versions during validation. Cherry-picked from #1376 --------- Co-authored-by: zaniebot <242828183+zaniebot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELF validation limits
GLIBC_*symbol versions but does not limit theGCC_*versions required from the allowedlibgcc_s.so.1. This lets distributions pass with compiler-runtime dependencies unavailable on supported systems, including theGCC_11.0andGCC_12.0.0requirements introduced by native_Float16conversions in the Python 3.16.0a1 AArch64 and x86-64 GNU/Linux builds, respectively.Apply target-specific
GCC_*limits to GNU/Linux targets that allowlibgcc_s.so.1:GCC_4.8.0on x86-64,GCC_4.7.0on ARMv7 and AArch64, andGCC_7.0.0on RISC-V, based on the Buster sysroot.