Repository navigation
Use PowerShell for the Windows build step - #1384
Merged
Merged
Conversation
jjhelmus
added
platform:windows
Contributor
|
LGTM but want to run a full Windows matrix to validate the environment variables are correctly passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zizmor flags the Windows build step because it uses
cmd, which is difficult to analyze reliably. The build script already initializes the Visual Studio environment, so the step no longer needs CMD for that setup.Run the step with PowerShell and pass the same build arguments using PowerShell environment-variable syntax. This removes the
misfeaturefinding without suppressing it.Fixes https://github.com/astral-sh/python-build-standalone/security/code-scanning/33.