Skip to content

Use patch files for Windows source changes - #1388

Merged
zanieb merged 1 commit into
astral-sh:mainfrom
zaniebot:windows-source-patches
Oct 24, 2026
Merged

zanieb merged 1 commit into
astral-sh:mainfrom
zaniebot:windows-source-patches

Conversation

@zaniebot

Copy link
Copy Markdown
Contributor

Windows builds encode fixed CPython and OpenSSL changes as inline replacements, and the xz fallback can leave a partially modified project when a later replacement fails. Move these edits into version-selected patches applied with git apply, normalizing line endings for CRLF project files and failing the build when a patch no longer applies. Build-specific paths and versions remain generated in Python.

Remove the obsolete _sqlite3.vcxproj and _freeze_importlib rewrites for the supported CPython versions.

@zanieb zanieb added arch:all Select all architectures build:all platform:windows Specific to the Windows platform python:all Select all Python versions labels Oct 22, 2026
@zaniebot
zaniebot force-pushed the windows-source-patches branch from 0a0fdb0 to 8d96e65 Compare October 22, 2026 06:32
@zanieb
zanieb marked this pull request as ready for review October 22, 2026 17:55
@zanieb
zanieb requested a review from jjhelmus October 22, 2026 20:04
@zanieb
zanieb merged commit a9277c4 into astral-sh:main Oct 24, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch:all Select all architectures build:all platform:windows Specific to the Windows platform python:all Select all Python versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants