Repository navigation
Fix type and equality issues in problem classes - #154
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of small, independent fixes for type and consistency issues in the analysis and detective classes.
Changes
UnsupportedClassVersionProblem: Only add theUpdateJavaSolutionif a Java version could be determined. Previouslynullcould be passed to the solution's non-nullable constructor, resulting in aTypeError.MinecraftProblem:isEqual()now uses$insight instanceof staticinstead of comparingget_class()results. This matches how the subclasses that overrideisEqual()already check the type.Bukkit\PluginDependencyProblem:getDependencyPluginName()now returnsstringinstead of?string. The backing property is a non-nullablestring, and this matches the Pocketmine counterpart.Detective: Use the correct class name casingWaterFallProxyLog::class, matching the class declaration and the import.Behaviour notes
MinecraftProblem::isEqual()is slightly broader than beforegetDependencyPluginName()is compatible for callers, but a subclass overriding it with?stringwould have to be adjusted.