Repository navigation
Use named pattern keys in forge mod problems - #156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModDependencyProblemandModFatalProblemswitched on the numeric array index of theirgetPatterns()entries (case 0:,case 1:, …). Reordering or inserting a pattern would silently change which branch ofsetMatches()handles a match, without any error.Change
Both classes now use descriptive string keys, consistent with
FabricModDependencyProblemandFabricModIncompatibleMinecraftVersionProblem:ModDependencyProblem:requires-mods,missing-mods-exception,mod-loading-exception,loading-failed-exceptionModFatalProblem:mod-state,failed-to-load