Skip to content

Fix PHPDoc generics for query results and model collections #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthi4s merged 1 commit into from
Oct 29, 2026
Merged

Fix PHPDoc generics for query results and model collections #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/GenericModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ public static function get(string $id, bool $update = false, bool $saveToRegistr
* Query the model
*
* @param Query $query
* @return QueryResult<static>|static[]
* @return QueryResult<static>
* @noinspection PhpDocSignatureInspection
*/
public static function query(Query $query): QueryResult
Expand Down Expand Up @@ -545,7 +545,7 @@ public static function query(Query $query): QueryResult
* @param array|int|Limit|null $limit
* @param array|GroupField[]|string[]|null $group
* @param bool $saveResultsToRegistry Whether results of this query should be saved in the model registry.
* @return QueryResult<static>|static[]
* @return QueryResult<static>
* @throws ModelException
* @noinspection PhpDocSignatureInspection
*/
Expand Down Expand Up @@ -580,7 +580,7 @@ public static function count(null|WhereCondition|array|WhereGroup $where = null)
* @param array|null|WhereCondition|WhereGroup $where
* @param array|null $order
* @param array|int|Limit|null $limit
* @return QueryResult<static>|static[]
* @return QueryResult<static>
* @noinspection PhpDocSignatureInspection
*/
public static function update(null|array $fields = null,
Expand Down Expand Up @@ -682,7 +682,7 @@ public function delete(): bool
* dataset
*
* @param array $data
* @return QueryResult<static>|static[]
* @return QueryResult<static>
* @noinspection PhpDocSignatureInspection
*/
public function set(array $data): QueryResult
Expand Down
2 changes: 2 additions & 0 deletions src/ModelCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
* Class ModelCollection
*
* @template TModel of ModelInterface
* @implements Iterator<int, TModel>
* @implements ArrayAccess<int, TModel>
* @package Aternos\Model
*/
class ModelCollection implements Iterator, Countable, ArrayAccess
Expand Down
Loading