Repository navigation
Give the FAQ example test time to finish on Windows Node 20 - #83
Merged
Merged
Conversation
The local pass/fail example exceeded the 20s test limit on that runner, and cleanup then failed with EBUSY because the fixture server still held the temp directory. Co-authored-by: Jeff Skafi <jeffskafi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both open dependabot PRs fail CI on the same check: Node 20 on Windows. The FAQ chatbot example test runs several local CLI passes and hits the 20 second Vitest limit on that runner. Cleanup then throws
EBUSYbecause the fixture server is still holding the temp directory.This gives that test the same 120 second budget used by the other multi-command integration tests, and stops the fixture server the same way those tests do: wait for exit, then
SIGKILL, and retry a locked Windows directory remove.Testing
npx vitest run test/examples/faq-chatbot.test.tspassed locally (4 tests).Slack Thread