Skip to content

feat: enhance login tracking with additional properties for first login events - #1717

Merged
developerkunal merged 2 commits into
mainfrom
DXCDT-2487/login-tracking-properties
Oct 19, 2026
Merged

developerkunal merged 2 commits into
mainfrom
DXCDT-2487/login-tracking-properties

Conversation

@ramya18101

@ramya18101 ramya18101 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🔧 Changes

Login analytics events (CLI - Auth0 - First Login and ... - As-User / ... - As-Machine) were sent with no extra properties, only version, os and arch. That made logins from short-lived CI jobs impossible to attribute: each fresh job gets a new install ID, and nothing on the event said which tenant it was for or whether CI, an agent or a person ran it.

Login events now carry the same attribution context that command-run events already have:

Property Value
tenant Domain just logged into
ci true / false, from the existing CI environment detection
agent_client Detected agent name, or empty
interactive true / false, whether stdin and stdout are terminals

🔬 Testing

  • New table-driven TestLoginTrackingProperties covers the tenant value, ci inside and outside CI, the interactive value, and that exactly four properties are sent.
  • go test ./internal/analytics/ ./internal/cli/ passes, and golangci-lint reports no issues for both packages.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal
developerkunal marked this pull request as ready for review October 19, 2026 12:26
@developerkunal
developerkunal requested a review from a team as a code owner October 19, 2026 12:26
@developerkunal
developerkunal merged commit f05ce2f into main Oct 19, 2026
10 checks passed
@developerkunal
developerkunal deleted the DXCDT-2487/login-tracking-properties branch October 19, 2026 12:26
@ramya18101
ramya18101 removed the request for review from a team October 19, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants