fix: use authzed.v1/ prefix for FGAM permission names - #584
Open
ivanauth wants to merge 1 commit into
Open
Conversation
The `zed backup`/`zed restore` section of restricted-api-access and the role definitions in the Postgres FDW guide used an `authzed.api/` prefix for FGAM permission names. That prefix does not exist: FGAM permissions are namespaced with `authzed.v1/` (PermissionNamePrefix in the FGAM schema), which is also what the role example further down the same restricted-api-access page uses. A reader following either section would grant permission names that match nothing and get PermissionDenied with no indication of the cause.
Contributor
|
Preview deployment skipped — @ivanauth does not have write access to this repository. A maintainer can trigger a preview deployment by re-running this workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FGAM permission names are namespaced with
authzed.v1/, but two places in the docs use anauthzed.api/prefix that does not exist:restricted-api-access— thezed backup/zed restoresection (7 names)authzed/guides/postgres-fdw— the FDW role definitions (20 names)