Repository navigation
Remove Boop action receipts (revert #312) - #314
brianorwhatever wants to merge 1 commit into
Conversation
|
🚅 Deployed to the boop-pr-314 environment in Friends
|
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. This is a clean git revert of the #312 merge, and the head tree is byte-identical to main just before #312 (git diff 0f53694^1 HEAD is empty). It restores a state that has already shipped and been deployed.
Reviewed changes
I reviewed the single revert commit against main:
- Receipt issuance removed:
convex/receipts.ts,convex/lib/serviceReceipts.ts,shared/receipt.tsand the scheduling inrecordActionsare deleted.actionRecordswrites go back to a plain insert. - Service DID removed:
convex/serviceDid.ts,shared/serviceDid.ts, the scripts, the docs and the Turnkey receipt-signer policy are deleted.didProxy.tsDID_LOGmatches onlyuser-*paths again. - Schema: the optional
actionRecords.receiptfield is dropped. As the PR body says, Convex rejects the deploy only if a row carries it. turnkeyApi.tsfolded back intoconvex/authInternal.ts. This is a pure move, and no other code imports it.
No references to the removed modules, env vars or the boop-service path are left in the repo. The remaining "receipt" matches all belong to the unrelated offlineReceipts replay feature.
ℹ️ A published service DID log would outlive the revert
The deploy note covers the Turnkey key. If serviceDid:publish was ever run in prod, though, its didLogs row at path boop-service stays in the table. Convex's /d/ handler would keep serving it at /d/boop-service/did.jsonl. boop.ad/boop-service/did.jsonl would no longer resolve, because didProxy.ts no longer matches that path. It is harmless, but it is worth deleting together with the Turnkey key if it exists.
claude-opus-5-5 | 𝕏

Reverts #312 (merge
0f53694). Receipts were merged but never switched on.Why: authorization is moving into the Originals spec. There, each write is an author or editor entry under the spec's editor grants (P5.15–P5.18). The current spec decides that asset logs have no witnesses (D3, P9.8). It handles backdating by a revoked key structurally: an editor entry must build on a parent that still grants it, so a backdated write forks visibly (P5.17, P6.6), and only anchoring settles the fork. A Boop-countersigned receipt is a witness under another name, so it duplicates that and goes against D3.
What this removes:
convex/receipts.ts,convex/lib/serviceReceipts.ts,convex/serviceDid.tsshared/receipt.ts,shared/serviceDid.ts, thedidProxy.tsboop-servicepathreceiptfield onactionRecordsconvex/lib/turnkeyApi.tsextraction, which goes back intoconvex/authInternal.ts. It's a pure move and nothing else uses it.Deploy note: merging deploys prod Convex and web. Convex will only accept removing
actionRecords.receiptif no row has one. Receipts were only issued whenACTION_RECEIPTS_ENABLED=true, so none should exist. If any do, the deploy refuses and nothing breaks. Any Turnkey service-DID key created during setup can be deleted separately.Testing:
bun test895 pass, 0 fail;tsc --noEmitis clean.🤖 Generated with Claude Code