fix(export): match harness allowedTools for customer tools and keep model parameters - #2456
Open
amhegazy-mp4 wants to merge 1 commit into
Open
amhegazy-mp4 wants to merge 1 commit into
amhegazy-mp4 wants to merge 1 commit into
Conversation
amhegazy-mp4
force-pushed
the
fix/export-harness-fidelity
branch
from
September 29, 2026 19:57
247d056 to
86eca92
Compare
amhegazy-mp4
force-pushed
the
fix/export-harness-fidelity
branch
from
September 29, 2026 20:25
86eca92 to
667fe6c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2456 +/- ##
=========================================
Coverage 97.23% 97.23%
=========================================
Files 606 606
Lines 42479 42475 -4
=========================================
- Hits 41304 41301 -3
+ Misses 1175 1174 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…odel parameters - allowedTools: a bare pattern selects builtins only, and @server selects a customer tool (MCP server, inline function, gateway, browser, code interpreter), as the harness runtime does. Previously @server dropped the tool and a bare name kept it; a bare builtin name ("shell") now also selects the builtin, as intended. - Service model additionalParams for bedrock, open_ai, and gemini are carried into the generated model loader instead of being dropped with a note. The local harness spec still omits them, since its deploy schema accepts them only for lite_llm.
amhegazy-mp4
force-pushed
the
fix/export-harness-fidelity
branch
from
September 30, 2026 06:15
667fe6c to
e69b854
Compare
Merged
8 of 18 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
agentcore export harnessnow matches the harness it exports in two places:allowedToolsfor configured tools. A bare pattern (shell,file_*) selects built-in tools only, and@nameselects a configured tool (MCP server, inline function, gateway, browser, code interpreter), as the harness does. Previously@namedropped the tool and a barenamekept it. A bare built-in name such asshellnow also selects the built-in, which previously required@builtin/shell.matchesAllowedToolsnow takes the server and tool separately instead of a flattened name.additionalParams. Forbedrock,open_ai, andgemini,export harness --arncarries the harness model'sadditionalParamsinto the generatedmodel/load.py(Bedrockadditional_args;paramsfor Mantle, OpenAI, and Gemini) instead of dropping them with an export note. Explicit model settings (temperature, max tokens, ...) take precedence. The local harness spec still omits the field, sinceharness.yamlaccepts it only forlite_llm, so the values are passed to the export alongside the spec.Behavior changes for new exports: a bare configured-tool name in
allowedToolsno longer keeps that tool (use@name), matching the harness.Related Issue
Closes #2455
Documentation PR
Not applicable.
Type of Change
Testing
bun testbun run test:e2e, or explained why they are not applicable: there are no export end-to-end tests. Instead I rendered an export and ran it against Bedrock:allowedTools: ["@mcp"]kept the MCP server and the model called its tool, and Bedrock accepted the carried-overadditionalParams.bun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed them (no snapshots changed)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.