feat(tui): show eval in the menu outside a project - #2471
Merged
Merged
Conversation
Evaluation does not need a local project, so users who haven't created one yet can now find and use eval from the root menu. 💘 Generated with Crush Assisted-by: Crush:us.anthropic.claude-opus-5-5
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, focused change that removes eval from NO_PROJECT_HIDDEN_OPTIONS so users can access evaluation from the root menu without a local project. I verified:
- Nothing in
src/handlers/eval/**(or itsscreen.tsx/index.tsxrouter setup) references project loading (getProject/loadProject/inProject), so eval is safe to invoke outside a project. The project-scopedadd online-evalhandler lives underadd/, which remains hidden — good. - The two updated test assertions in
RouterScreen.test.tsxandtui.test.tsxcorrectly mirror the new behavior, and no other tests or docs reference the previous hidden-eval invariant. - No new user-facing feature requiring telemetry; no new mocking introduced.
Nothing blocking. LGTM to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2471 +/- ##
=========================================
Coverage 97.26% 97.27%
=========================================
Files 620 623 +3
Lines 44241 44313 +72
=========================================
+ Hits 43033 43105 +72
Misses 1208 1208 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
notgitika
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this change,
evalwas hidden from the root TUI menu whenever you weren't inside an AgentCore project. You don't need a local project to run an evaluation, so this change listsevalin the menu outside a project too, next to the resource commands. Commands that do need a project (such asaddanddeploy) are still hidden.I updated the menu tests to match: outside a project they now check that
evalis listed.Related Issue
Follow-up to #2433. No issue linked yet.
Closes #
Documentation PR
Not applicable.
Type of Change
Testing
bun testbun run test:e2e, or explained why they are not applicable (not applicable: this only changes the TUI menu)bun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.
💘 Generated with Crush