Skip to content

feat(tui): show eval in the menu outside a project - #2471

Merged
AlexanderRichey merged 1 commit into
refactorfrom
feat/show-eval-outside-project
Sep 30, 2026
Merged

AlexanderRichey merged 1 commit into
refactorfrom
feat/show-eval-outside-project

Conversation

@AlexanderRichey

Copy link
Copy Markdown
Contributor

Description

Before this change, eval was hidden from the root TUI menu whenever you weren't inside an AgentCore project. You don't need a local project to run an evaluation, so this change lists eval in the menu outside a project too, next to the resource commands. Commands that do need a project (such as add and deploy) are still hidden.

I updated the menu tests to match: outside a project they now check that eval is listed.

Related Issue

Follow-up to #2433. No issue linked yet.

Closes #

Documentation PR

Not applicable.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable (not applicable: this only changes the TUI menu)
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

💘 Generated with Crush

Evaluation does not need a local project, so users who haven't created
one yet can now find and use eval from the root menu.

💘 Generated with Crush

Assisted-by: Crush:us.anthropic.claude-opus-5-5
@github-actions github-actions Bot added the size/xs PR size: XS label Sep 30, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 30, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 30, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, focused change that removes eval from NO_PROJECT_HIDDEN_OPTIONS so users can access evaluation from the root menu without a local project. I verified:

  • Nothing in src/handlers/eval/** (or its screen.tsx / index.tsx router setup) references project loading (getProject/loadProject/inProject), so eval is safe to invoke outside a project. The project-scoped add online-eval handler lives under add/, which remains hidden — good.
  • The two updated test assertions in RouterScreen.test.tsx and tui.test.tsx correctly mirror the new behavior, and no other tests or docs reference the previous hidden-eval invariant.
  • No new user-facing feature requiring telemetry; no new mocking introduced.

Nothing blocking. LGTM to merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 30, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (c845bee) to head (5c57a51).
⚠️ Report is 3 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2471   +/-   ##
=========================================
  Coverage     97.26%   97.27%           
=========================================
  Files           620      623    +3     
  Lines         44241    44313   +72     
=========================================
+ Hits          43033    43105   +72     
  Misses         1208     1208           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexanderRichey
AlexanderRichey merged commit b266e6b into refactor Sep 30, 2026
21 of 22 checks passed
@AlexanderRichey
AlexanderRichey deleted the feat/show-eval-outside-project branch September 30, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants