fix(tui): use consistent colors for CLI-only commands - #2490
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, focused fix: drops the muted color for CLI-only entries so they render like other menu items, and removes the now-unused cliOnly field from Option. The only remaining use of the cliOnly local at RouterScreen.tsx:148-149 is section placement, which is still correct.
The new test is a nice approach — spawning a child process with FORCE_COLOR=3 to bypass the global FORCE_COLOR=0 set in src/testing/setup.ts (only preloaded for bun test) is a reasonable way to assert on ANSI output without disturbing the plain-text frame assertions used elsewhere. Since bun test's process.execPath is bun, the --eval script's TS/ESM/top-level-await works.
Minor nit (not blocking): on failure the test only asserts result.status === 0 without surfacing result.stderr, which will make future debugging harder if it ever regresses. Not worth blocking on.
Nothing else to flag — no new telemetry needed (bug fix, not a feature), and the test avoids mocking entirely by rendering through the real Root.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2490 +/- ##
============================================
- Coverage 97.39% 97.39% -0.01%
============================================
Files 642 642
Lines 46807 46801 -6
============================================
- Hits 45590 45584 -6
Misses 1217 1217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the report, @codecov-commenter — feedback like this is exactly Would you mind opening a new issue so we can track it properly? If this is a security issue, please report it privately via |
Description
CLI-only commands are selectable in the TUI but their names were gray. Give every command name the same styling: white when idle and cyan when highlighted.
Option.cliOnlyfield.Screenshot
Captured from the updated CLI with the TUI harness at 100 columns by 30 rows.
feedback,config, andupdateuse the same white labels as the resource commands.Related Issue
Not applicable. No issue created for this small UX fix.
Documentation PR
Not applicable. No commands or configuration changed.
Type of Change
Testing
bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed thembun test: 3,950 passed, 0 failed. Focused menu and CLI-only navigation tests: 133 passed, 0 failed. Typecheck, lint, formatting, and build passed.Real-AWS end-to-end tests are not applicable: this change only affects menu label styling. The updated CLI was launched and visually checked through the TUI harness.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.