Refactor ec2 run-instances _fix_args to use a param map - #10563
Open
Adityaj0 wants to merge 1 commit into
Open
Conversation
Replaces six near-identical if-blocks that move scalar top-level params into the NetworkInterfaces structure with a declarative source-to-destination key map and a loop, keeping the PrivateIpAddress case separate since it needs real transformation. No behavior change. Fixes aws#10562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10562
_fix_argsinawscli/customizations/ec2/runinstances.pymoved several scalar top-level params (SubnetId,SecurityGroupIds,Ipv6AddressCount,Ipv6Addresses,EnablePrimaryIpv6) into theNetworkInterfaces[0]structure via six nearly-identicalif key in params: interface[dest] = params[key]; del params[key]blocks.This replaces those blocks with a declarative
simple_param_map(source key -> destination key) and a loop, keeping thePrivateIpAddresscase as the one special-cased transform (it needs to be wrapped into aPrivateIpAddresseslist, not just renamed).Pure refactor — no behavior change.
Test plan
python3 -m pytest tests/functional/ec2/test_run_instances.py -q— 23 passed