Skip to content

fix(strands): ban experimental import - #686

Draft
Hweinstock wants to merge 3 commits into
aws:mainfrom
Hweinstock:fix/ban-strands-experimental-imports
Draft

Hweinstock wants to merge 3 commits into
aws:mainfrom
Hweinstock:fix/ban-strands-experimental-imports

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

The AgentCore Python SDK imported APIs from strands.experimental, creating a dependency on unstable Strands interfaces.

Solution

  • Remove experimental Strands imports and their obsolete Bidi-specific hooks/tests.
  • Add Ruff TID251 configuration banning strands.experimental imports.

Verification

  • unit tests pass: 185 passed.
  • Memory session-manager integration tests pass: 12 passed in 10m28s

@Hweinstock Hweinstock changed the title Fix/ban strands experimental imports fix(strands): ban experimental import Sep 28, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Sep 28, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@3a6496e). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage        ?   89.53%           
=======================================
  Files           ?      124           
  Lines           ?    10719           
  Branches        ?     1675           
=======================================
  Hits            ?     9597           
  Misses          ?      734           
  Partials        ?      388           
Flag Coverage Δ
unittests 89.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 28, 2026

This branch had an error being deployed

1 failed deployment
auto-approve — 9029e23d Deployed Sep 28, 2026 by Hweinstock via Test (identity) #1610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants