Repository navigation
Conversation
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
alexr-bq
reviewed
Sep 10, 2026
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Signed-off-by: Edward Liang <liawedwa@amazon.com>
Collaborator
There was a problem hiding this comment.
Really solid port, 1:1 with the Python library on the parity contract. Four small comments inline (centralize the Node version matrix, add macOS to CI, swap the GLIDE example for a client without built-in IAM auth, drop examples from files). One more: please add node/CHANGELOG.md in Keep-a-Changelog format with an Unreleased entry, since versions and releases are per-language. Thank you!
P.S. no need for the CLI :)
alexr-bq
approved these changes
Sep 11, 2026
Signed-off-by: Edward Liang <liawedwa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a Node.js library for generating Amazon ElastiCache IAM authentication tokens. It supports serverless caches and node-based replication groups through a typed API and a reusable token provider.
The change also adds Node CI, package validation, examples, documentation, and focused coverage for signing, configuration resolution, credential refresh, validation, and published-package exports.
What's in it
node/srcElastiCacheIAMAuthTokenProvider.node/examplesnode/testnode/package.json.github/workflows/node.yml.github/dependabot.ymlREADME.md,node/README.mdDesign decisions
ElastiCacheIAMAuthTokenProvider.create()resolves the region before returning so missing configuration fails during setup. The synchronous constructor retains the error and reports it fromgetToken().Tests
npm run lint— passed.npm run typecheck— passed.npm test— passed, 56 tests.npm run format:check— currently fails becausenode/src/errors.tscontains trailing whitespace.Not in this PR
Signed-off-by: Edward Liang liawedwa@amazon.com