Tighten warnMissingIds types and drop redundant Set values() calls

[kmcginnes]

Summary

Follow-ups from the review of #2245: tighter types on warnMissingIds, no redundant .values() calls on Sets, and a REVIEW.md rule that had been buried inside another bullet.

-warnMissingIds<T extends VertexId | EdgeId>(
-  entityLabel: "edges" | "vertices",
-  requested: readonly T[], found: readonly T[],
-  context: { data?: unknown; response?: unknown },
-)
+warnMissingIds<Label extends "vertices" | "edges">(
+  entityLabel: Label,
+  requested: readonly EntityIdByLabel[Label][], found: readonly EntityIdByLabel[Label][],
+  response: unknown,
+)

• "vertices" now only accepts VertexId[], and "edges" only accepts EdgeId[].
• Every connector passes its raw response the same way. The warning logs it under response, not data for Gremlin and openCypher and response for SPARQL.
• Array.from(set.values()) becomes Array.from(set) at the 11 sites where the receiver is a Set. Map receivers keep .values().
• REVIEW.md: "Production code that imports a devDependency" is now its own bullet instead of trailing the Runtime APIs item.

Evidence

After: warnMissingIds.test.ts uses @ts-expect-error to check that edge ids can't be reported as vertices and vertex ids can't be reported as edges. It also checks that the logged payload is { requested, missing, response }.

Merge Danger

Door: two-way

Impact: logging

For Gremlin and openCypher, the missing-ids warning now logs the database response under response instead of data.

Related

• Related to Stop using Iterator helpers and other above-floor APIs so core-js can be removed #2245
• Related to Stop using Iterator helpers so core-js can be removed #2180

[kmcginnes]

Approved