Repository navigation
Fail the Docker test build when the Vite+ image and vite-plus versions differ - #2442
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Vite+ image tag in the
Dockerfileand thevite-pluscatalog version inpnpm-workspace.yamlmust be the same release. Only comments kept them in step, and Dependabot opens a separate PR for each, so one could merge without the other. The Docker test build now fails while they differ.User-facing: none
test-build-docker-image Checkout + Ensure the Vite+ image matches the vite-plus catalog version Build Docker image ...It also carries 3 review fixes from #2435 that missed its merge:
docs/development.md: a Vite+ upgrade changes both pins in the same PR.docs/development.md:docker buildpulls fromghcr.ioas well aspublic.ecr.aws, so a registry allowlist needs both.Dockerfile: a comment ties therm -rf ... packages/*/node_modulesglob topnpm-workspace.yaml, and says why it isn'tvp run clean:dep.Evidence
Before: a Dockerfile on
vite-plus:1.2.0with the catalog on1.1.0passed CI.After: I ran the new step locally against each case:
1.1.0in both: passes1.2.0:FAIL: Dockerfile has vite-plus:1.1.0, pnpm-workspace.yaml has vite-plus 1.2.01.2.0: failsFROMline without a tag and digest: fails"1.1.0"): passesMerge Danger
Door: two-way
Impact: CI
The image doesn't change. A future Vite+ bump PR fails the Docker test build until both pins move together.
Related