Repository navigation
Add the Vite+ block to AGENTS.md and drop the Husky self-heal - #2453
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents should use the same
vpcommands the Vite+ docs and CI use, and the Husky self-heal inpreparewas only there for clones from before the Vite+ switch, which the docs now cover.User-facing: none
prettier-ignore. Without it the pre-commit formatter reflows the block's hard-wrapped paragraph, the next install rewrites it back, and every fresh clone ends up with a dirtyAGENTS.md.docs/development.mdnow covers clones still pointing at Husky: unsetcore.hooksPath, thenpnpm run prepare.pnpm installcan skippreparewhen it reports "Already up to date", so the old "install again" advice didn't always reinstall the hook.docs/agents/testing.mdnamesvp checkandvp test. The pnpm scripts stay as aliases for humans, and the PR template is unchanged.Evidence
Verified live:
CI=true pnpm install --frozen-lockfilerunsvp config, leavesAGENTS.mdunchanged, and setscore.hooksPathto.vite-hooks/_. The pre-commit hook ran on the commits in this branch.pnpm run preparerestores the block byte for byte.core.hooksPath=.husky/_, install printscore.hooksPath is already set to ".husky/_", skippingand exits 0. Aftergit config --unset core.hooksPathandpnpm run prepare, the hook is back.vp test <path>andvp test -tselect the same files and tests as theirpnpm testforms.Merge Danger
Door: two-way
Impact: tooling
Clones from before the Vite+ switch that haven't run
pnpm installsince then lose the pre-commit hook until their owners follow the docs. CI runs the same checks.