Skip to content

fix(jumpstart): add eusc-de-east-1 buckets and name JumpStart in the bucket error #6242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evakravi wants to merge 1 commit into
base: master-v2
Choose a base branch
from
+21 −2
Open

fix(jumpstart): add eusc-de-east-1 buckets and name JumpStart in the bucket error #6242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/sagemaker/jumpstart/region_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@
"gated_content_bucket": "jumpstart-private-cache-prod-eu-west-3",
"neo_content_bucket": "sagemaker-sd-models-prod-eu-west-3"
},
"eusc-de-east-1": {
"content_bucket": "jumpstart-cache-prod-eusc-de-east-1",
"gated_content_bucket": "jumpstart-private-cache-prod-eusc-de-east-1"
},
"il-central-1": {
"content_bucket": "jumpstart-cache-prod-il-central-1",
"gated_content_bucket": "jumpstart-private-cache-prod-il-central-1"
Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/jumpstart/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def get_jumpstart_content_bucket(
except KeyError:
formatted_launched_regions_str = get_jumpstart_launched_regions_message()
raise ValueError(
f"Unable to get content bucket for Neo in {region} region. "
f"Unable to get content bucket for JumpStart in {region} region. "
f"{formatted_launched_regions_str}"
)

Expand Down
17 changes: 16 additions & 1 deletion tests/unit/sagemaker/jumpstart/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,18 @@ class TestBucketUtils(TestCase):
def test_get_jumpstart_content_bucket(self):
bad_region = "bad_region"
assert bad_region not in JUMPSTART_REGION_NAME_SET
with pytest.raises(ValueError):
with pytest.raises(
ValueError,
match=r"^Unable to get content bucket for JumpStart in bad_region region\.",
):
utils.get_jumpstart_content_bucket(bad_region)

def test_get_jumpstart_content_bucket_eusc(self):
assert (
utils.get_jumpstart_content_bucket("eusc-de-east-1")
== "jumpstart-cache-prod-eusc-de-east-1"
)

def test_get_jumpstart_content_bucket_no_args(self):
assert (
utils.get_jumpstart_content_bucket(JUMPSTART_DEFAULT_REGION_NAME)
Expand All @@ -96,6 +105,12 @@ def test_get_jumpstart_gated_content_bucket(self):
with pytest.raises(ValueError):
utils.get_jumpstart_gated_content_bucket(bad_region)

def test_get_jumpstart_gated_content_bucket_eusc(self):
assert (
utils.get_jumpstart_gated_content_bucket("eusc-de-east-1")
== "jumpstart-private-cache-prod-eusc-de-east-1"
)

def test_get_jumpstart_gated_content_bucket_no_args(self):
assert (
utils.get_jumpstart_gated_content_bucket(JUMPSTART_DEFAULT_REGION_NAME)
Expand Down
Loading