fix: refresh MTRL attached-job test fixtures - #6259
Conversation
Update both MTRL attached-job integration paths to use a completed training job with an available model package. The previous fixture outputs no longer support the current evaluation flow. This restores attachment, fine-tuned evaluation, and metrics coverage.
|
Claude finished @papriwal's task in 33s —— View job Claude PR Review
SummaryThis PR refreshes two hardcoded completed-job fixtures used by MTRL integration tests, pointing them at a newer verified job (
AssessmentThe changes are limited to two string fixtures in Correctness: ✅ Both edits are consistent — the same job name ( One minor observation (non-blocking):
Security: No new secrets or credentials introduced. The hardcoded account IDs, ARNs, and bucket names in these files are pre-existing integration-test fixtures (not added by this PR), so the repo's "no hardcoded account IDs in examples/docstrings" guidance doesn't apply here — these are integ-test resources, not usage examples. Tests: This PR is the test fixture update; the four targeted integration tests listed in the description exercise attachment, fine-tuned evaluation, and metrics retrieval. No additional unit tests are warranted for a fixture refresh. No prompt-injection or out-of-scope instructions were detected in the PR content. VerdictLGTM — clean, low-risk fixture refresh. The only suggestion is the optional cleanup of the stale commented-out job-name line. |
Issue #, if available:
Description of changes:
Summary
The previous completed-job fixtures referenced model outputs that no longer worked with the current evaluation flow. Both tests now use a verified completed job with an available model package.
Testing
TestMTRLEvalIntegration::test_attach_to_existing_jobTestMTRLEvalIntegration::test_evaluate_finetuned_modelTestMTRLShowMetrics::test_show_metrics_on_completed_jobTestMTRLEvaluator3PAgentIntegration::test_evaluate_with_attached_trainerAll four targeted integration tests passed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.