Skip to content

Daily Sync with Botocore v1.43.96 on 2026/09/17 - #6285

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-17-10-06-58
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-17-10-06-58

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 24s —— View job


Review: Daily Botocore Sync PR #6285

  • Read PR diff
  • Review generated Python code (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Review service model JSON changes
  • Post review summary

This is an automated, code-generated sync from Botocore v1.43.96. I reviewed the generated Python for internal consistency, breaking changes, and correctness. The PR looks clean — the changes across the four generated files are mutually consistent and I found no bugs.

What the sync adds (verified consistent across shapes.pyshape_dag.pyresources.py)

  • AIRecommendationJob: new adapter_source (LoRA) param on create/attribute; new shapes AIAdapterSource, AIAdapterModelPackageEntry, AIAdapterS3Entry, AIRecommendationAdapterDetails — all defined in shapes.py and mirrored in shape_dag.py. ✅
  • MLflow benchmarking: new AIMlflowConfig shape, wired into AIBenchmarkOutputConfig/AIBenchmarkOutputResult. Correctly defined before first use (module-level annotations resolve). ✅
  • MlflowApp: new kms_key_id on the resource, create, and the config_schema.py MlflowApp properties. ✅
  • ModelCard / ModelPackage: new included_data param on get/refresh. ✅
  • PartnerApp: new idc_config (IdcConfigInput/IdcConfigOutput) and auth_type on update. ✅
  • Endpoint invoke: new prefix_aware_id on invoke/invoke_with_response_stream; new s3_output_path_extension, filename, body on invoke_async.
  • Endpoint.wait_for_status: target_status Literal extended with PendingMaintenance, InMaintenance. ✅

Observations (informational, inherent to the upstream model — no action needed)

  • AsyncEndpoint.invoke_async signature change is technically backward-incompatible for positional callers (resources.py, ~L10787). input_location moved from a required, first positional parameter to an optional keyword parameter, and several new params (s3_output_path_extension, filename, body) were inserted before the trailing timeout args. A caller doing endpoint.invoke_async("s3://...") positionally would now bind that string to content_type. This faithfully reflects the upstream Botocore change (InputLocation is now optional, mutually exclusive with the new inline Body), so it's expected for a sync — flagging only for release-note awareness, not as a defect.
  • update_record docstring regeneration (resources.py, ~L12314): the ConflictException/ResourceNotFound descriptions became the generic shared-shape wording (e.g. "modify a SageMaker entity such as an Experiment or Artifact"), which reads as slightly less specific than the previous FeatureStore-tailored text. This is a consequence of the featurestore-runtime model reclassifying ConflictException as synthetic and reusing the shared error shape — a doc-only change, not a behavior change.

Tests

No unit tests are included, which is consistent with prior daily-sync PRs (the changes are purely generated from the service models). No new hand-written logic was introduced that would require tests.

No prompt-injection attempts were found in the diff or PR metadata.
· branch botocore-sync-2026-09-17-10-06-58

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.16%. Comparing base (4fa702c) to head (04b7431).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6285      +/-   ##
==========================================
+ Coverage   71.13%   71.16%   +0.03%     
==========================================
  Files         553      553              
  Lines       68376    68459      +83     
==========================================
+ Hits        48637    48720      +83     
  Misses      19739    19739              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant