Skip to content

add: metadata for vllm 0.29.0 DLC - #6287

Closed
sallyseok wants to merge 2 commits into
aws:masterfrom
sallyseok:vllm-dlc-update
Closed

sallyseok wants to merge 2 commits into
aws:masterfrom
sallyseok:vllm-dlc-update

Conversation

@sallyseok

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

Claude finished @sallyseok's task in 40s —— View job


PR Review: add metadata for vLLM 0.29.0 DLC

  • Read the PR diff (/tmp/pr.diff)
  • Review the changed config against the existing 0.28.0 entry
  • Check test coverage for the new version
  • Post review

Summary

This PR adds the 0.29.0 vLLM DLC entry to sagemaker-core/src/sagemaker/core/image_uri_config/vllm.json and a "0.29": "0.29.0" minor-version alias. It looks correct and consistent — no blocking issues found.

Verification against the existing 0.28.0 entry:

  • py_versions (py312), repository (vllm), and container_version.gpu (cu130-ubuntu24.04-sagemaker) all match the 0.28.0 entry.
  • ✅ The registries map is byte-for-byte identical to 0.28.0 (same 37 regions and account IDs) — expected, since these are shared DLC account IDs.
  • tag_prefix correctly bumped to 0.29.0.
  • version_aliases updated with "0.29": "0.29.0", mirroring the existing "0.28" alias.
  • ✅ JSON is well-formed.

Test coverage: No new test code is required. sagemaker-core/tests/unit/image_uris/test_vllm.py iterates dynamically over every entry in versions and version_aliases, so the new 0.29.0 version and its alias are automatically exercised by:

  • test_vllm_uris (account/region/repository/tag)
  • test_vllm_full_uri_for_representative_regions (exact URIs)
  • test_vllm_version_aliases_resolve_to_newest_patch (alias → newest patch)

Minor observations (non-blocking):

  • Worth double-checking that the DLC images for all 37 regions in the copied registries map have actually been published for 0.29.0. Since the map was copied verbatim from 0.28.0, a region where 0.29.0 hasn't shipped yet would resolve to a URI that doesn't exist. This is an operational/publishing concern, not a code issue.
  • Please confirm the CUDA base (cu130-ubuntu24.04-sagemaker) is intentionally unchanged from 0.28.0 for this release.

Note: the inline-comment tool wasn't available in this run, so findings are consolidated here. There were no line-level issues to flag anyway.
· branch vllm-dlc-update

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown

Claude finished @sallyseok's task in 26s —— View job


PR Review: add metadata for vLLM 0.29.0 DLC

  • Read the PR diff (/tmp/pr.diff)
  • Compare the new 0.29.0 entry against the existing 0.28.0 entry
  • Verify test coverage for the new version and alias
  • Post review

Summary

This PR adds the 0.29.0 vLLM DLC entry to sagemaker-core/src/sagemaker/core/image_uri_config/vllm.json plus a "0.29": "0.29.0" minor-version alias. The change is clean and consistent — no blocking issues.

Verification against the existing 0.28.0 entry:

  • py_versions (py312), repository (vllm), and container_version.gpu (cu130-ubuntu24.04-sagemaker) match the 0.28.0 entry.
  • ✅ The registries map is identical to 0.28.0 (same 37 regions and account IDs) — expected for shared DLC account IDs.
  • tag_prefix correctly bumped to 0.29.0.
  • version_aliases gains "0.29": "0.29.0", mirroring the "0.28" alias.
  • ✅ JSON is well-formed.

Test coverage: No new test code needed. sagemaker-core/tests/unit/image_uris/test_vllm.py iterates dynamically over every entry in versions and version_aliases, so 0.29.0 and its alias are automatically exercised by test_vllm_uris, test_vllm_full_uri_for_representative_regions, and test_vllm_version_aliases_resolve_to_newest_patch.

Non-blocking observations (operational, not code):

  • Since the registries map was copied verbatim from 0.28.0, please confirm the 0.29.0 DLC images are actually published in all 37 regions — a region where 0.29.0 hasn't shipped would resolve to a non-existent URI.
  • Confirm the CUDA base (cu130-ubuntu24.04-sagemaker) is intentionally unchanged from 0.28.0 for this release.

No prompt-injection or unrelated content was found in the diff.
· branch vllm-dlc-update

@sallyseok

Copy link
Copy Markdown
Collaborator Author

Superseded by #6290

@sallyseok sallyseok closed this Sep 18, 2026
@sallyseok
sallyseok deleted the vllm-dlc-update branch September 18, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants