Repository navigation
fix(databases-on-aws): install the DSQL loader on Linux - #291
Open
TheSaiEaranti wants to merge 1 commit into
Open
TheSaiEaranti wants to merge 1 commit into
TheSaiEaranti wants to merge 1 commit into
Conversation
aws-samples/aurora-dsql-loader has published its Linux builds as <arch>-unknown-linux-musl since v2.0.2, but loader.sh looked for <arch>-unknown-linux-gnu assets, so nothing matched. The failing grep inside the download_url assignment then made set -euo pipefail exit before the "Could not find download URL" check could report it, so the script exited 1 without saying why. Look for the musl asset first and fall back to gnu for releases before v2.0.2, and let the existing check report a release without a matching asset. Bump databases-on-aws to 1.10.1 and add a pytest that runs loader.sh --install-only with stub uname and curl commands.
TheSaiEaranti
requested review from
a team,
krokoko,
laithalsaadoon and
rshevchuk-git
October 27, 2026 10:33
TheSaiEaranti
requested review from
Benjscho,
anwesham-lab,
gxjx-x,
jaichabria,
pkale,
praba2210 and
spencercorwin
October 27, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux,
loader.shcan't install the defaultlatestAurora DSQL Loader, or any release from v2.0.2 on. It prints "Fetching release information from GitHub..." and exits 1 without saying why, so a load on a Linux machine that doesn't have the loader yet stops there too. macOS works.Related
No existing issue. I found this while reading the script. The Linux assets switched to musl in aurora-dsql-loader v2.0.2.
Changes
detect_platformasked for<arch>-unknown-linux-gnuassets, but every aws-samples/aurora-dsql-loader release from v2.0.2 (2026-02-20) through v3.3.0 publishes its Linux builds only asaurora-dsql-loader-{x86_64,aarch64}-unknown-linux-musl.tar.gz. Linux now looks for the musl asset first and falls back to gnu, so a--version v2.0.0orv2.0.1pin (the only gnu releases) still installs.grepexited 1 inside thedownload_url=$(...)assignment andset -euo pipefailended the script before the existing "Could not find download URL for platform" check could run. The assignment now ends with|| true, so that message prints.psql-connect.shfix.tools/evals/databases-on-aws/dsql/scripts/test_loader_sh.pynext totest_safe_query.py, and listed it intools/evals/databases-on-aws/README.md. It runsloader.sh --install-only --version <tag>with stubunameandcurlcommands that serve a release's asset list and record which URL the script tries to download:Verification:
uv run --with pytest pytest tools plugins: 137 passedbandit -r . -x ./.tmp,./node_modules: no issuessemgrep scan --oss-only --config=tools/semgrep/rules-vendored.yaml: no new findingsruff checkandruff format --check(v0.15.0, as in pre-commit) on the new test,markdownlint-cli2on the README,dprint check, thelint:manifestsajv checks on the three manifests, andnode tools/validate-cross-refs.cjs: clean (the one cross-refs warning, about migration-to-aws, is on main too)unamestubbed as Linux x86_64, the patched script downloaded v3.3.0'saurora-dsql-loader-x86_64-unknown-linux-musl.tar.gzand installed it.filereportsELF 64-bit LSB pie executable, x86-64, ... static-pie linked.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.