Repository navigation
Fix single-interval ConsolidateIntervals indexing - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single 1-by-2 interval makes
length(intervals)return 2, soConsolidateIntervalsattempts to accessdone(2)even though there is only one interval. This causesCleanLFPand callers such asauto_theta_cyclesto fail when exactly one artefact is detected.Use
size(intervals,1)in both consolidation loops to iterate over interval rows. Add eight regression tests covering single row and column intervals, strict mode, empty input, overlap consolidation and target mapping, touching bounds, andCleanLFPwith one amplitude artefact, one derivative artefact, or no artefacts.Validation: reproduced the original indexing error before the fix; all eight tests pass after the fix in MATLAB R2025a.