[Nyeriah]

Changes Proposed

Follow-up to #507. Four more vendors sell the same emblem upgrades:

• Usuri Brightcoin (35790): Emblem of Triumph for 1 Emblem of Frost (extended cost 2743) and Emblem of Conquest for 1 Emblem of Triumph (2707).
• Goodman the "Closer" (38858): Emblem of Triumph for 1 Emblem of Frost (2743).
• Arcanist Asarina (35573) and Magistrix Iruvia (35574): Emblem of Conquest for 1 Emblem of Triumph (2707).

Their rows are added to the same three files: Bracket_0 removes them, Bracket_80_3 restores the Triumph -> Conquest trades and Bracket_80_4_1 the Frost -> Triumph trades. The restored rows match the stock npc_vendor rows.

Issues Addressed

#507 only covered Magister Arlan, Arcanist Uovril, Arcanist Miluria and Magistrix Vesara, so the upgrade was still reachable through these four vendors.

SOURCE

Same as #507: Emblem of Triumph arrived in 3.2 and Emblem of Frost in 3.3.

Tests Performed

Applied the extended Bracket_0 delete on a live realm running up to Bracket_80_2. No vendor sells Emblem of Triumph for extended cost 2743 or Emblem of Conquest for 2707 afterwards, and the Conquest -> Valor and Valor -> Heroism trades are untouched.

How to Test the Changes

1. Enable brackets up to Bracket_80_2 and let the updater run.
2. Usuri Brightcoin, Goodman the "Closer", Arcanist Asarina and Magistrix Iruvia should no longer sell Emblem of Triumph or Emblem of Conquest for a higher emblem.
3. Enable Bracket_80_3 and the Triumph -> Conquest trades come back; enable Bracket_80_4_1 and the Frost -> Triumph trades come back.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0b7358cb-1b56-42e1-b5dc-3d3294d2cf3d

📥 Commits

Reviewing files that changed from the base of the PR and between eb8e63c and 10052c0.

📒 Files selected for processing: 3

• src/Bracket_0/sql/world/progression_0_npc_vendor_emblem_exchange.sql
• src/Bracket_80_3/sql/world/progression_0_npc_vendor_emblem_exchange_down_1.sql
• src/Bracket_80_4_1/sql/world/progression_0_npc_vendor_emblem_exchange_down_2.sql

+----------------------------------------+
| Where we're going, we don't need bugs. |
+----------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}