[EricksOliveira]

What and why

Closes #44.

The SQL file is already in a folder the core imports on its own. At startup the DB updater looks at each compiled module's data/sql/ and picks every subfolder whose name contains the DB name, which is world for the world DB (UpdateFetcher.cpp, DBUpdater.cpp). So data/sql/db-world/ gets applied, and it's the same layout as https://github.com/azerothcore/skeleton-module. The wiki page in the issue only covers the core's own data/sql/ tree, not modules.

The only change is deleting data/sql/updates/world/.dummy. The updater never reads data/sql/updates/, and a folder with that name makes it look like the SQL is in the wrong place. #31 did the same for updates/char.

Decisions worth knowing

• The SQL file stays where it is, byte for byte.
• The README's old install step (manual import or db_assembler.sh) is fixed in fix: Repair the XP rate cap and SQL install step #49, so this PR leaves the README alone to avoid a conflict there.
• include.sh stays. It's empty, and the core still sources modules/*/include.sh, so it has nothing to do with this issue.

Review guide

One deleted placeholder file, nothing else.

Known gaps

• Until fix: Repair the XP rate cap and SQL install step #49 is merged, the README still shows the old install text.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: d14d1e10-d9dd-4a7d-a3be-5bb6c02aff08

📥 Commits

Reviewing files that changed from the base of the PR and between 7442879 and 049e741.

📒 Files selected for processing: 1

• data/sql/updates/world/.dummy

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[EricksOliveira]

Self-review — chore-remove-sql-updates-dummy → master

Outcome No findings in 2 rounds, final round clean

Reviewed 049e741 (chore-remove-sql-updates-dummy vs upstream/master, merge-base diff, 1 file, +0 −1), PR #51 title and description

By Claude Code (desktop app), Opus 5.5 (claude-opus-5-5), self-review v0.14, 2026-10-17

Testing in game by the author: the worldserver applied mod-weekend-xp-texts.sql with state MODULE, and the .weekendxp messages show

Review details (round 2)

Intent Resolve #44 by removing the placeholder folder data/sql/updates/, keeping the module's SQL file where it is.

Project rules module repo has none; applied the core's .agents/docs/self-review-rules.md (pinned review, in-game testing ask)

Diff 63eead38db3433e5fd6fbe4ff07c81c762f83cc2

Metadata 9d1ad219701d145511f1b00858289dbd9be18dc1

Round 1 (code diff, clean) is in the earlier report. The diff hash is unchanged since then.

Round 2, 049e741, PR metadata only (title, description and linked issue added when PR #51 was opened), clean