Skip to content

Fix direct upload with Windows drive names - #62

Merged
avni merged 1 commit into
mainfrom
codex/fix-windows-direct-upload
Oct 27, 2026
Merged

avni merged 1 commit into
mainfrom
codex/fix-windows-direct-upload

Conversation

@crnicholson

Copy link
Copy Markdown
Contributor

The editor rejected selected drives unless their directory handle name was exactly BADGER, preventing connection when Windows exposed a drive letter or a different volume name. Validate that the selected root contains an apps directory instead, with a clear error for invalid selections and unchanged permission and device errors.

Adds regression tests for Windows drive names, renamed volumes, invalid folders, and device errors.

Validation on current main: 250 editor tests and 14 app-description tests pass; production build and git diff --check pass. Physical Windows upload verification remains pending.

Copilot AI balanced review requested due to automatic review settings October 27, 2026 18:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow change implements the intended validation with regression coverage and no identified blocking issues; physical Windows verification remains pending.

No open issues 🎉

What changed in this PR

Fixes editor direct-upload connections when Windows exposes a drive letter or the badge volume has been renamed.

Changes:

  • Validates the selected root by checking for an apps directory instead of requiring the name BADGER.
  • Adds a clear invalid-selection error while preserving permission and device errors.
  • Adds regression tests for alternate drive names, invalid selections, and error propagation.
File Description
tests/​badge-editor-upload.test.mjs Adds root-validation regression tests.
src/​lib/​badge-editor.ts Uses the shared validator during device connection.
src/​lib/​badge-editor-upload.ts Adds directory-based badge root validation.

Review effort: Balanced

@avni
avni merged commit 0e5a817 into main Oct 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants