Repository navigation
Fix direct upload with Windows drive names - #62
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change implements the intended validation with regression coverage and no identified blocking issues; physical Windows verification remains pending.
No open issues 🎉
What changed in this PR
Fixes editor direct-upload connections when Windows exposes a drive letter or the badge volume has been renamed.
Changes:
- Validates the selected root by checking for an
appsdirectory instead of requiring the nameBADGER. - Adds a clear invalid-selection error while preserving permission and device errors.
- Adds regression tests for alternate drive names, invalid selections, and error propagation.
| File | Description |
|---|---|
| tests/badge-editor-upload.test.mjs | Adds root-validation regression tests. |
| src/lib/badge-editor.ts | Uses the shared validator during device connection. |
| src/lib/badge-editor-upload.ts | Adds directory-based badge root validation. |
Review effort: Balanced
avni
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor rejected selected drives unless their directory handle name was exactly
BADGER, preventing connection when Windows exposed a drive letter or a different volume name. Validate that the selected root contains anappsdirectory instead, with a clear error for invalid selections and unchanged permission and device errors.Adds regression tests for Windows drive names, renamed volumes, invalid folders, and device errors.
Validation on current main: 250 editor tests and 14 app-description tests pass; production build and
git diff --checkpass. Physical Windows upload verification remains pending.