Repository navigation
Fix inactive Connect button on cached simulator pages - #63
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The deployment workflow can fail before deploying the current site when a selected artifact has expired after its default one-day retention, with no explicit retention policy or fallback for missing artifacts.
1 open issue
What changed in this PR
This PR addresses inactive controls on cached simulator pages by preserving older build assets so the editor can still initialize.
Changes:
- Retrieve assets from the previous two successful Pages deployments.
- Preserve matching assets without replacing current files, and record each build’s own assets to prevent indefinite accumulation.
- Add regression coverage for asset preservation, current-file precedence, and expiration.
| File | Description |
|---|---|
| tests/page-assets.test.mjs | Tests preservation, exclusions, current-file precedence, and asset expiration. |
| scripts/preserve-page-assets.mjs | Copies eligible historical assets and writes the current build’s asset manifest. |
| .github/workflows/deploy.yml | Downloads previous deployment artifacts and preserves assets before upload. |
Review effort: Balanced
avni
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Cached simulator HTML still references
entry.Dgpr0kmR.jsafter the Windows upload deployment, but that asset returns 404. The editor never initializes, leaving Connect badge with no click handler.Preserve hashed JavaScript, imported chunks, and CSS from the previous two successful Pages deployments. Keep the current HTML and assets authoritative, and record each build's own asset list so old files expire instead of accumulating indefinitely.
Validation:
E:disk: Connect, app listing, install with read-back confirmation, cancellation, and visible invalid-folder errors.git diff --checkpass.Browser disk tests use simulated directory handles. Physical Windows USB testing remains pending. The live site requires this PR to be merged and deployed.