Repository navigation
Feat/ Add propose and apply beside verify on rv mcp - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rv mcpnow servesverify,propose, andapply.verifyis the only pass. Its arguments and result are unchanged:project_path, optionalcontracts_path, and a result ofexit_code,scan, anderror.proposereturns the same connection-proposal fields asrv connections propose, as JSON:decided,needs_choice,conflict, andcitations. It does not write a file unlesswriteis true, in which case it writes.architon/connections.proposal.yamlunder the same--forcerule as the CLI. Aneeds_choiceentry lists every candidate and does not mark a GPIO accepted.applytakes a proposal path and runs the same label apply asrv connections apply. It returnsfiles_changedandids_applied. It does not return an exit code for the design. Aneeds_choiceentry is skipped. An accepted entry may name a pin only by copying a name or number from that entry'scandidates. Any other pin is rejected and no schematic is written.propose, thenapply, thenverify, to reportexit_codeand each finding, and to treat a clean verify withscan.coverage.not_checkedrows as a pass of the proved checks only. The schematic is edited only throughapply.Test plan
rv mcplistsverify,propose, andapply.verifystill accepts onlyproject_pathand optionalcontracts_path.proposeandapplyresults have noexit_code.proposeon the I2C fixture returnsneeds_choicefor the ESP32 and does not mark a GPIO accepted. Withwriteomitted,.architon/connections.proposal.yamlis not created.proposewithwrite: truewrites that file. A second call withoutforceleaves the file unchanged.force: trueoverwrites it.applyof an accepted pin that is not in that entry'scandidatesreturns an error, emptyfiles_changedandids_applied, and does not change the schematic.applyof a pin copied from that entry'scandidatesadds one net label and returns the schematic path and the entry id. Aneeds_choiceentry is skipped.verifyonexamples/agent-loop/brokenstill returnsexit_code2, andscan.coverage.not_checkedis still in the result.rv connections applystill prints changed schematic paths and applied ids, exits 3 when a candidate pin is not in the list, and writes nothing in that case.