Repository navigation
Type the event callback in the generated stubs - #6
Merged
Merged
Conversation
The event_callback parameter was typed typing.Any, leaving embedders without a checked contract. The stubs now declare it as typing.Optional[collections.abc.Callable[[SessionEvent], typing.Any]] via a gen_stub argument type override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event_callbackwas typedtyping.Anyin the generated stubs, leaving embedders without a checked contract. The stubs now declare it astyping.Optional[collections.abc.Callable[[SessionEvent], typing.Any]]via agen_stubargument type override on both session constructors.Stub-only change; no runtime behavior difference. Ships as 0.5.1 so Rayforge can consume the typed callback signature.
Test plan
make stubsregenerated; diff shows only the callback signature.make check: 159 tests passed; fmt/clippy/ruff/pyright green.