Skip to content

fix(checks): restore reinitializer checker - #412

Open
Mabolla wants to merge 1 commit into
base:mainfrom
Mabolla:agent/restore-reinitializer-check-v2
Open

fix(checks): restore reinitializer checker#412
Mabolla wants to merge 1 commit into
base:mainfrom
Mabolla:agent/restore-reinitializer-check-v2

Conversation

@Mabolla

@Mabolla Mabolla commented Aug 21, 2026

Copy link
Copy Markdown

Summary

  • restore the missing scripts/checks/reinitializer checker referenced by just reinitializer-check-no-build
  • adapt the checker to use this repository's local scripts/checks/common package
  • restore the local just check / just pre-pr path without changing the existing recipes

Why

just check currently invokes go run ./scripts/checks/reinitializer, but that package is absent from the tree, so the check chain aborts before later checks can run. The checker existed when the contracts were imported into this repository and the equivalent implementation still exists upstream in Optimism, which indicates the missing package is the regression rather than the justfile target.

Closes #410.

Validation

  • git diff upstream/main...HEAD --check
  • verified the branch differs from main by exactly one added file: scripts/checks/reinitializer/main.go
  • local go test ./scripts/checks/reinitializer could not be run because Go is not installed in the Windows environment used for this contribution

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@Mabolla
Mabolla marked this pull request as ready for review August 21, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

just check and just pre-pr fail: scripts/checks/reinitializer does not exist

2 participants