fix(checks): restore reinitializer checker - #412
Open
Mabolla wants to merge 1 commit into
Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
Mabolla
marked this pull request as ready for review
August 21, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/checks/reinitializerchecker referenced byjust reinitializer-check-no-buildscripts/checks/commonpackagejust check/just pre-prpath without changing the existing recipesWhy
just checkcurrently invokesgo run ./scripts/checks/reinitializer, but that package is absent from the tree, so the check chain aborts before later checks can run. The checker existed when the contracts were imported into this repository and the equivalent implementation still exists upstream in Optimism, which indicates the missing package is the regression rather than thejustfiletarget.Closes #410.
Validation
git diff upstream/main...HEAD --checkmainby exactly one added file:scripts/checks/reinitializer/main.gogo test ./scripts/checks/reinitializercould not be run because Go is not installed in the Windows environment used for this contribution