Stop injecting Basecamp context into every session - #675
Open
almirsarajcic wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes have no unresolved approval-blocking issues.
Pull request overview
Removes unconditional Basecamp context injection while retaining skill discovery and commit-reference hooks.
Changes:
- Removes the
SessionStarthook. - Updates Codex setup guidance.
- Adds regression coverage preventing its restoration.
File summaries
| File | Description |
|---|---|
README.md |
Clarifies Codex hook and skill behavior. |
internal/release/manifests_test.go |
Prevents SessionStart from returning. |
internal/commands/wizard_codex.go |
Removes obsolete hook commentary. |
internal/commands/wizard_codex_test.go |
Updates setup guidance test commentary. |
install.md |
Updates Codex installation guidance. |
hooks/hooks.json |
Removes unconditional session context injection. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing and trusting the Basecamp plugin registers an unconditional
SessionStarthook. Every new Codex or Claude Code session then receives:That context is injected even in repositories and conversations unrelated to Basecamp. It can steer the agent toward Basecamp simply because the plugin is installed.
This is separate from normal skill discovery: the Basecamp skill should remain available for natural-language requests and explicit references.
Change
SessionStarthook from the shared plugin manifest.PreToolUse,PostToolUse, andPostToolUseFailure).SessionStartfrom returning to the plugin hook manifest.No
.basecamp/config.jsonis required to activate the skill. Codex can continue selecting it when a request is relevant.Verification
go test ./internal/releasego test ./internal/commands -run TestRunCodexSetupInteractiveExplainsNextSteps -count=1git diff --checkmake checkpassed vet, lint, Actionlint, and zizmor, then hit pre-existing terminal-detection failures because the Codex command runner is not recognized as an interactive terminal.Summary by cubic
Removes the unconditional
SessionStarthook so Basecamp no longer injects context into every Codex or Claude Code session. The Basecamp skill stays available for relevant requests and explicit references.Details
PreToolUse,PostToolUse,PostToolUseFailure).SessionStartfrom returning to the hook manifest.Written for commit 9b6cf0d. Summary will update on new commits.