Preserve account context in template library breadcrumbs - #683
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are focused, tested, and have no unresolved issues.
Pull request overview
Preserves profile and account context in template-library copy breadcrumbs.
Changes:
- Appends active profile and account flags to copy breadcrumbs.
- Adds regression coverage for profile quoting and account propagation.
File summaries
| File | Description |
|---|---|
internal/commands/templates.go |
Appends resolved context arguments to the library copy breadcrumb. |
internal/commands/templates_test.go |
Tests profile quoting and flag-sourced account propagation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
templates librarycopy breadcrumb.Why
Following the advertised copy command after running
templates librarywith a one-off--profileor--accountcould resolve against a different account in the next process. The other template copy and status breadcrumbs already carry this context.Testing
bin/ciSummary by cubic
Preserves the active profile and account selection in the
templates librarycopy breadcrumb so the advertised command works against the same account in the next process. Previously, following the breadcrumb after a one-off--profileor--accountcould resolve against a different account.--profileand--accountflags to the copy breadcrumb when they are set.Written for commit 54be488. Summary will update on new commits.