Skip to content

Preserve account context in template library breadcrumbs - #683

Merged
robzolkos merged 1 commit into
mainfrom
fix/template-library-context
Sep 3, 2026
Merged

Preserve account context in template library breadcrumbs#683
robzolkos merged 1 commit into
mainfrom
fix/template-library-context

Conversation

@robzolkos

@robzolkos robzolkos commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What

  • Preserve the active profile and any process-local account selection in the templates library copy breadcrumb.
  • Cover profile quoting and flag-sourced account propagation with a regression test.

Why

Following the advertised copy command after running templates library with a one-off --profile or --account could resolve against a different account in the next process. The other template copy and status breadcrumbs already carry this context.

Testing

  • bin/ci

Summary by cubic

Preserves the active profile and account selection in the templates library copy breadcrumb so the advertised command works against the same account in the next process. Previously, following the breadcrumb after a one-off --profile or --account could resolve against a different account.

  • Appends --profile and --account flags to the copy breadcrumb when they are set.
  • Adds a regression test covering profile quoting and flag-sourced account propagation.

Written for commit 54be488. Summary will update on new commits.

Review in cubic

Copilot AI balanced review requested due to automatic review settings September 3, 2026 21:32
@github-actions github-actions Bot added commands CLI command implementations tests Tests (unit and e2e) labels Sep 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are focused, tested, and have no unresolved issues.

Pull request overview

Preserves profile and account context in template-library copy breadcrumbs.

Changes:

  • Appends active profile and account flags to copy breadcrumbs.
  • Adds regression coverage for profile quoting and account propagation.
File summaries
File Description
internal/commands/templates.go Appends resolved context arguments to the library copy breadcrumb.
internal/commands/templates_test.go Tests profile quoting and flag-sourced account propagation.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@robzolkos
robzolkos merged commit 5eef7ce into main Sep 3, 2026
25 checks passed
@robzolkos
robzolkos deleted the fix/template-library-context branch September 3, 2026 21:39
@robzolkos robzolkos added the bug Something isn't working label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working commands CLI command implementations tests Tests (unit and e2e)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants