Skip to content

Count the time the polls take toward the release wait, not just the sleeps - #218

Merged
jeremy merged 1 commit into
mainfrom
release-wait-wall-clock
Oct 20, 2026
Merged

jeremy merged 1 commit into
mainfrom
release-wait-wall-clock

Conversation

@jeremy

@jeremy jeremy commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

#201's wait loop added 30 to ELAPSED per sleep, so each poll's request and jq ran on top of the 5.5-hour budget. Over ~660 polls that overhead can push the loop past the job's timeout-minutes: 340, and the job gets killed before it prints the "Timed out waiting" error and final status.

This uses bash's SECONDS, which measures wall-clock time, so the wait ends at 19,800 s and leaves about 10 minutes of the 340 for the report. It's the same fix as hey-sdk f26a09b, which came from Copilot's finding on hey-sdk#264.

The request budget is unchanged: one actions/runs request per 30 s poll, about 120 an hour against GITHUB_TOKEN's 1,000.


Summary by cubic

Fixes the release wait loop so wall-clock time, not just the sleep intervals, counts toward the 5.5-hour budget.

  • The old ELAPSED counter added 30 s per sleep, ignoring each poll's API request and jq processing, so ~660 polls could push the loop past the job's 340-minute timeout before the "Timed out waiting" error and final status printed.
  • Bash's SECONDS measures wall-clock time, ending the wait at 19,800 s and leaving about 10 minutes of the 340 for the report.
  • The request budget is unchanged: one actions/runs request per 30 s poll.

Written for commit f700e55. Summary will update on new commits.

View guided diff Turn on auto-fix

Each poll's request and jq add to the 30s sleep, so a counter of sleeps alone ran past 5.5 hours and could reach the job's 340-minute limit before the timeout error reported. SECONDS measures the wall clock. Ports hey-sdk f26a09b.
Copilot AI balanced review requested due to automatic review settings October 20, 2026 06:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T06:50:45.156279Z f700e55 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The focused timer change correctly includes polling overhead without changing release gating, and no blocking issues remain.

No open issues 🎉

What changed in this PR

Corrects the release wait introduced in #201 so polling overhead counts toward the 5.5-hour budget.

Changes:

  • Replaces the sleep-only counter with Bash’s SECONDS.
  • Updates elapsed-time logging while preserving polling frequency and release gating.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
.github/​workflows/​release-github.yml Counts requests, processing, and sleeps toward the release wait budget.

Review effort: Balanced

@jeremy
jeremy merged commit d5a93c0 into main Oct 20, 2026
47 checks passed
@jeremy
jeremy deleted the release-wait-wall-clock branch October 20, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants