Repository navigation
Bump hey-sdk to v0.34.0 - #602
Conversation
Moves github.com/basecamp/hey-sdk/go from v0.33.1 to v0.34.0 with no CLI call-site changes: every client the CLI builds carries its own auth strategy, so the SDK's new refusal of a client with no credentials does not reach it, and the CLI does not use the SDK's oauth package. The MCP model snapshot is synced from go/v0.34.0. It now carries HEY's OAuth token endpoint (CreateToken, RevokeToken) under the OAuth tag, which stays unmapped on purpose: exchanging a code or revoking a token is the CLI's own sign-in, never a tool to hand an agent. The pinned unmapped-tag list says so. nix/package.nix's vendorHash is recomputed and its build verified.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
The dependency and snapshot updates are consistent, client authentication remains compatible, and OAuth operations remain excluded from MCP tools.
No open issues 🎉
What changed in this PR
Updates HEY CLI to hey-sdk v0.34.0 and synchronizes its MCP model snapshot without changing CLI commands or exposing OAuth operations as agent tools.
Changes:
- Bumps the SDK dependency and refreshes Go checksums and the Nix vendor hash.
- Syncs OAuth schemas and operation behavior metadata from the SDK release.
- Pins OAuth as intentionally excluded from the MCP tool catalog.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
nix/package.nix |
Updates the vendor hash for the dependency bump. |
internal/mcpserver/model/PROVENANCE.json |
Records the v0.34.0 source ref and commit. |
internal/mcpserver/model/openapi.json |
Adds OAuth token operations and schemas. |
internal/mcpserver/model/behavior-model.json |
Adds OAuth operations and authentication/redirect metadata. |
internal/mcpserver/catalog_test.go |
Pins OAuth among intentionally unmapped tags. |
go.sum |
Updates SDK checksums. |
go.mod |
Requires hey-sdk v0.34.0. |
Review effort: Balanced
* origin/main: Render nested Action Text attachment content (#335) Add hey thread comment for private thread notes (#383) Select threads with x as well as space (#359) Bump hey-sdk to v0.34.0 (#602) Update nix flake and plugin version for v1.10.1 (#600) Say why a refused Keychain read can't be fixed by signing in again (#599)
Summary
Moves
github.com/basecamp/hey-sdk/gofrom v0.33.1 to the published v0.34.0 release. No CLI call sites change and no commands are added.What HEY CLI picks up:
oauthpackage.initSDK,newSDKClient,newUncachedSDKClient) passes its own auth strategy, so none of them is affected.MCP model snapshot
internal/mcpserver/model/is synced from hey-sdk atgo/v0.34.0withmake update-mcp-model. The newoperations,
CreateTokenandRevokeToken, arrive under a newOAuthtag, andbehavior-model.jsongains
unsignedandno_redirectfor every operation.OAuthstays unmapped on purpose. Exchanging a code or revoking a token is the CLI's own sign-in,never a tool to hand an agent: one could revoke the very session the MCP server runs on. The pinned
list in
TestCatalogUnmappedTagsArePinnednow includes it, with that reason.Nix
nix/package.nix'svendorHashis recomputed withmake update-nix-hash, and the build is verified.Verification
make checkpasses: fmt, vet, golangci-lint v2.14.0 (the CI pin; 0 issues), unit tests, skill sync,tidy, surface and release lockstep.