Repository navigation
Conversation
adding this helps avoid confusion when scanning for CVEs affecting the system CVE-2018-13730 is for cpe:2.3:a:hey_project:hey:-:*:*:*:*:*:*:* that has nothing to do with hey-cli.
Contributor
There was a problem hiding this comment.
🟢 Approved
The narrowly scoped metadata change matches the stated purpose, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Adds CPE metadata to the Nix package to distinguish hey-cli from the unrelated hey_project:hey product in vulnerability scans.
Changes:
- Sets the CPE vendor to
basecampand product tohey-cli, using the package’s version.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
nix/package.nix |
Adds vendor, product, and version metadata for CPE identification. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding this helps avoid confusion when scanning for CVEs affecting the system
currently sbomnix reports
CVE-2018-13730 is for cpe:2.3:a:hey_project:hey:-:::::::* that has nothing to do with hey-cli.
Adding a correct cpe would remove this false positive
Summary by cubic
Fixes false-positive CVE reports for hey-cli by adding the correct CPE identifier to the Nix package metadata.
Without it, vulnerability scanners match hey-cli against the unrelated CVE-2018-13730, which targets
hey_project:hey. The new CPE identifies the package asbasecamp:hey-cli, so scans no longer flag this unrelated advisory.Written for commit 39d94a8. Summary will update on new commits.