Repository navigation
Add workflow stage reader - #141
Merged
jeremy merged 2 commits intoSep 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds HTML parsing support for reading workflow stage cards through Workflows.GetStage.
Changes:
- Adds workflow stage view/topic models and HTML parser.
- Adds a happy-path service test.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
go/pkg/hey/workflows.go |
Implements stage retrieval and HTML parsing. |
go/pkg/hey/services_test.go |
Tests parsing a populated stage card. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
almirsarajcic
force-pushed
the
feature/workflow-stage-topics
branch
from
September 1, 2026 11:36
f11ccd3 to
bd038c4
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
Author
|
Addressed both reviews: the route is now modeled and generated; the wrapper requests HTML without a manually constructed path; conformance and unit coverage cover the HTML representation, |
almirsarajcic
force-pushed
the
feature/workflow-stage-topics
branch
4 times, most recently
from
September 1, 2026 12:43
7b51031 to
8ed022f
Compare
almirsarajcic
force-pushed
the
feature/workflow-stage-topics
branch
from
September 1, 2026 12:44
8ed022f to
ada48dc
Compare
This was referenced Sep 10, 2026
Merged
jeremy
added a commit
that referenced
this pull request
Sep 10, 2026
* Make the gates green after the workflow stage reader #141 added GetWorkflowStage, HEY's first modelled route that answers HTML, and was merged on checks that had never run on it. Three gates went red on main: Go Tests and Go Lint: go/pkg/hey imports golang.org/x/net/html, which go.mod never declared. `go mod tidy` in go/ and in conformance/runner/go. Rust Tests: rust/hey-sdk/src/generated was not regenerated, and the generator had no notion of a text/html response, so it would have emitted a unit-returning method that sent `.json` with a JSON Accept. The model now reads a text/html 2xx as Response::Html, the service emitter asks for the page as HEY serves it (Operation::html_representation) and answers the body as a String through Client::send_text. The routes test pins the modelled-route count, now 131. Conformance Tests (Rust): the fixture #141 added had a Go dispatch arm only. The Rust runner gains the arm, serves an HTML fixture body as wire text the way the Go runner already does, and leaves the expected path of an HTML case alone rather than putting `.json` on it. * Let the route say it answers HTML, and name the stage it reads A Route now carries `html`, so Operation::for_route asks for such a page as written with `Accept: text/html` on its own, the emitter has nothing extra to say per method, and the conformance runner can tell from the operation rather than from what the mock happened to answer: an error case for the stage read mocks JSON and still goes to the bare path. GetWorkflowStage names a workflow_stage, as the Go wrapper and the hand-written stage writes already do. * Build the apidiff baseline from a tidied base checkout A main whose go.mod a merge left untidy gives apidiff nothing to load, so the PR repairing it fails the compatibility check on the base side and can never pass. The base checkout is throwaway; tidy it before reading its surface.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the generated
GetWorkflowStageHTML operation and parses its stage cards into thread metadata.CLI: basecamp/hey-cli#380