Repository navigation
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-github.ymlnow waits up to 5.5 hours for the release workflows, instead of the shared orchestrator's 30 minutes, becauserelease-cratesrequires a reviewer from sip or cli. This ports basecamp/fizzy-sdk#201's approach (at 8896f5e).Why:
release-cratesrequires approval now (sip or cli, with self-review prevented), butrelease-github.ymlcalledbasecamp/sdk/actions/release-orchestratewith its defaulttimeout: 1800. An approval that came after 30 minutes failed the GitHub release even though the crate published.What changes
actions/runs?head_sha=<tagged commit>&event=push. The shared action makes one or twogh run listrequests per language per poll. Over hours that outrunsGITHUB_TOKEN's 1,000 requests an hour.pathwith any@refsuffix stripped, plushead_branch == <tag>, newest first.timeout-minutes: 340.timeout: '1'andpoll-interval: '1', so it takes a single pass after the wait. Release creation (--generate-notes --latest), the failure summary and the recovery advice stay shared with the other SDK repos. Nothing else about it changes.GITHUB_SHA. That keepsgh workflow run release-github.yml -f tag=vX.Y.Zworking as the recovery path. fizzy-sdk#201 skips the wait on dispatch; hey-sdk's dispatch already relies on the shared action seeing the tag's push runs, so this keeps that.release-rust.ymlcomment saidrelease-crateshas "no required reviewers". They now say what it is: approval by sip or cli, not by whoever pushed the tag, and that a late approval needs a re-run of the orchestrator.Not in this PR
release-go,release-npmandrelease-github-packagesalready exist with the same reviewers and the samev*policy, but no workflow referencesrelease-goorrelease-github-packagesyet. Gating the Go module tag and the Kotlin publish the way fizzy-sdk does is a separate change.release-npmis used, but TypeScript publishing is off (.github/typescript-publish-enabledisfalse).Verified
actionlintandzizmor --offlinefind nothing inrelease-github.yml.jqagainst the real runs forv0.32.1. All five release workflows matched assuccess, and themainpush runs on the same commit were ignored.typescript/tests/release-workflow.test.ts's assertions onrelease-github.ymlstill hold:workflow_sha,release-languages.shand thelanguages:input are unchanged.Summary by cubic
Waits for reviewer-approved publish workflows before creating the GitHub release, instead of the shared orchestrator's 30-minute timeout.
release-github.ymlpolls the tag's push runs every 30 seconds for up to 5.5 hours, stopping early on the first failed run or when all succeed.timeout: '1'andpoll-interval: '1'; it still reports failures and creates the release.gh workflow runrecovery still works.CONTRIBUTING.mdand therelease-rust.ymlcomment to describerelease-crates's approval requirement (reviewer fromsiporcli, not the tag's author) and how to handle approvals arriving after the wait ends.Written for commit 5e79452. Summary will update on new commits.