Repository navigation
Conversation
…ents The probe required a registration_endpoint from every authorization server. HEY's lights up with pre-registered clients only and adds client ID metadata documents and dynamic registration later, and MCP now calls dynamic registration deprecated, so a server may offer only metadata documents. client_registration lists what must be advertised: dynamic (a registration_endpoint) and metadata_document (client_id_metadata_document_supported: true). Unset keeps [dynamic]; [] requires neither.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
client_registrationfield to themcpprobe from #183, so a probe can say which ways of registering a client its authorization server must advertise.For Lewis when it's ready.
Why
#183 requires a
registration_endpointfrom every authorization server. That holds for Basecamp and for Fizzy's OAuth train, but not for HEY:registration_endpoint: "HEY has no PAR, DCR, device, or introspection endpoints to advertise".So a HEY probe on #183 would fail from the day it's deployed, for a reason that isn't an outage.
What it does
dynamicrequires aregistration_endpoint, as before.metadata_documentrequiresclient_id_metadata_document_supported: true.[dynamic], so existing probes don't change.[]requires neither, while the authorization and token endpoints and S256 are still required.README, CHANGELOG (Unreleased → Added) and the install template's field list are updated.
Verification
mcp_probe_test.rb; that file passes (17 runs). Against the old probe, 5 of the 6 fail. The sixth, which requires both and gets a server withoutregistration_endpoint, passes either way, so it guards the "all listed" rule against a later change to "any listed".mtr, neither installed here. CI runs them.https://mcp.bc4-staging.com/mcp, AShttps://app.bc4-staging.com) with the field unset, set to[], and set to[dynamic, metadata_document]. All three pass.Not included
client_registration: []and needs Upright bumped once this merges.